Neels Hofmeyr has submitted this change and it was merged. (
https://gerrit.osmocom.org/10809 )
Change subject: inter-BSC HO outgoing: fix L3 forwarding
......................................................................
inter-BSC HO outgoing: fix L3 forwarding
Set msgb->l3h when composing the L3 message. Before this, the unset l3h
resulted in erratic size in the RSL L3 Info IE. This likely fixes inter-BSC
Handover on the outgoing side, to properly forward the RR Handover Command.
Change-Id: Ice37242c90c19adbf0795618fd16fe75f0809317
---
M src/osmo-bsc/abis_rsl.c
1 file changed, 2 insertions(+), 3 deletions(-)
Approvals:
Jenkins Builder: Verified
Neels Hofmeyr: Looks good to me, approved
diff --git a/src/osmo-bsc/abis_rsl.c b/src/osmo-bsc/abis_rsl.c
index 0dd27fd..589d673 100644
--- a/src/osmo-bsc/abis_rsl.c
+++ b/src/osmo-bsc/abis_rsl.c
@@ -683,14 +683,13 @@
int rsl_forward_layer3_info(struct gsm_lchan *lchan, const uint8_t *l3_info,
uint8_t l3_info_len)
{
struct msgb *msg;
- uint8_t *dst;
if (!l3_info || !l3_info_len)
return -EINVAL;
msg = rsl_msgb_alloc();
- dst = msgb_put(msg, l3_info_len);
- memcpy(dst, l3_info, l3_info_len);
+ msg->l3h = msgb_put(msg, l3_info_len);
+ memcpy(msg->l3h, l3_info, l3_info_len);
msg->lchan = lchan;
return rsl_data_request(msg, 0);
--
To view, visit https://gerrit.osmocom.org/10809
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ice37242c90c19adbf0795618fd16fe75f0809317
Gerrit-Change-Number: 10809
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr <nhofm...@sysmocom.de>
Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilira...@gmail.com>
