dexter has uploaded this change for review. ( https://gerrit.osmocom.org/10904


Change subject: MSC_ConnectionHandler: stop properly on failure in 
f_establish_fully()
......................................................................

MSC_ConnectionHandler: stop properly on failure in f_establish_fully()

When the altstep in f_establish_fully() gets an unexpected ASSIGNMENT
FAIL or COMPLETE it should stop completely like it is already
implemented in many other altsteps.

Change-Id: Ib4ac7bcbac35a4ae454d1806f3fbb727834d18b7
---
M bsc/MSC_ConnectionHandler.ttcn
1 file changed, 10 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/04/10904/1

diff --git a/bsc/MSC_ConnectionHandler.ttcn b/bsc/MSC_ConnectionHandler.ttcn
index 102c30e..9f67f1b 100644
--- a/bsc/MSC_ConnectionHandler.ttcn
+++ b/bsc/MSC_ConnectionHandler.ttcn
@@ -939,18 +939,28 @@
         (not st.is_assignment and (st.modify_done or not exp_modify))) and
         exp_compl] BSSAP.receive(tr_BSSMAP_AssignmentComplete) {
                setverdict(fail, "Received non-matching ASSIGNMENT COMPLETE");
+               all component.stop;
+               mtc.stop;
                }
        [exp_compl] BSSAP.receive(tr_BSSMAP_AssignmentFail) {
                setverdict(fail, "Received unexpected ASSIGNMENT FAIL");
+               all component.stop;
+               mtc.stop;
                }
        [not exp_compl] BSSAP.receive(tr_BSSMAP_AssignmentComplete) {
                setverdict(fail, "Received unexpected ASSIGNMENT COMPLETE");
+               all component.stop;
+               mtc.stop;
                }
        [not exp_compl] BSSAP.receive(tr_BSSMAP_AssignmentFail) {
                setverdict(fail, "Received non-matching ASSIGNMENT FAIL");
+               all component.stop;
+               mtc.stop;
                }
        [] T.timeout {
                setverdict(fail, "Timeout waiting for ASSIGNMENT COMPLETE");
+               all component.stop;
+               mtc.stop;
                }
        }
        log("g_media ", g_media);

--
To view, visit https://gerrit.osmocom.org/10904
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib4ac7bcbac35a4ae454d1806f3fbb727834d18b7
Gerrit-Change-Number: 10904
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pma...@sysmocom.de>

Reply via email to