Harald Welte has submitted this change and it was merged. (
https://gerrit.osmocom.org/10964 )
Change subject: codec_pref: fix missing breaks in switch-case statement
......................................................................
codec_pref: fix missing breaks in switch-case statement
In function test_codec_support_bts() the switch case statement lacks
break; statements for some cases. This may lead into messed up codec
decisions.
- Add missing break statements
Change-Id: Ib5400a0a0a8a39fa714bd087df345160bed5cc61
---
M src/osmo-bsc/codec_pref.c
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
Harald Welte: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/src/osmo-bsc/codec_pref.c b/src/osmo-bsc/codec_pref.c
index 96c2c38..924f77f 100644
--- a/src/osmo-bsc/codec_pref.c
+++ b/src/osmo-bsc/codec_pref.c
@@ -148,15 +148,19 @@
case GSM0808_PERM_FR2:
if (bts_codec->efr)
return true;
+ break;
case GSM0808_PERM_FR3:
if (bts_codec->amr)
return true;
+ break;
case GSM0808_PERM_HR1:
if (bts_codec->hr)
return true;
+ break;
case GSM0808_PERM_HR3:
if (bts_codec->amr)
return true;
+ break;
default:
return false;
}
--
To view, visit https://gerrit.osmocom.org/10964
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib5400a0a0a8a39fa714bd087df345160bed5cc61
Gerrit-Change-Number: 10964
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pma...@sysmocom.de>
Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
