Holger Freyther has posted comments on this change. ( https://gerrit.osmocom.org/10967 )
Change subject: Install to /bin as it doesn't require special privileges.. ...................................................................... Patch Set 2: > It's actually not easier since we support using adding binaries > from /sbin in there, but it's fine :) Ah I see: create_bin_tgz "" "osmocon" So maybe: create_binary_tgz "bin1 bin2" "sbin1 sbin2" But then we can't have spaces in binary names (yeah why would we) but that is a common problem of shell scripts. Alternatively: create_binary_tgz "bin1" "bin2" "sbin1" "sbin2" This makes it impossible to have an "osmocon" in both bin and sbin but then that would lead to oddities anyway. What do you think? -- To view, visit https://gerrit.osmocom.org/10967 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibe572a4c17871785b623e70acc7f5da056f945e5 Gerrit-Change-Number: 10967 Gerrit-PatchSet: 2 Gerrit-Owner: Holger Freyther <hol...@freyther.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Holger Freyther <hol...@freyther.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-CC: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Comment-Date: Sun, 16 Sep 2018 06:56:31 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No
