osmith has posted comments on this change. ( https://gerrit.osmocom.org/11053 )
Change subject: osmo-depcheck: don't use /tmp, better git code ...................................................................... Patch Set 1: (1 comment) pespin, neels: do you think this is ready to go? https://gerrit.osmocom.org/#/c/11053/1/scripts/osmo-depcheck/dependencies.py File scripts/osmo-depcheck/dependencies.py: https://gerrit.osmocom.org/#/c/11053/1/scripts/osmo-depcheck/dependencies.py@46 PS1, Line 46: try: > This part probably belongs to a separate specific feature, and could easily > go into a different patc […] Understood, I will split up my patches more in the future. Is this alright if we keep it this time (as this is a pretty new CI script, not production code), or should I split this one up as well? -- To view, visit https://gerrit.osmocom.org/11053 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I06589277b9d54a2af177451cfab2ca1a658b4058 Gerrit-Change-Number: 11053 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osm...@sysmocom.de> Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Reviewer: osmith <osm...@sysmocom.de> Gerrit-Comment-Date: Tue, 25 Sep 2018 09:46:25 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
