Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11148 )
Change subject: bts: Add parameter to set and expect a specific MS power level ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/11148/1/bts/BTS_Tests.ttcn File bts/BTS_Tests.ttcn: https://gerrit.osmocom.org/#/c/11148/1/bts/BTS_Tests.ttcn@1169 PS1, Line 1169: l1header := valueof(ts_SACCH_L1_HEADER(g_pars.l1_pars.ms_power_level, false, g_pars.l1_pars.ms_actual_ta)), > Also, I think it makes sense to use the parameters from L1 […] This is another improvement of the test, and I agree it makes sense but it can be done in a later patch later in time. -- To view, visit https://gerrit.osmocom.org/11148 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iedab8681a0ba4652a6bb1c001418599a4ff746b6 Gerrit-Change-Number: 11148 Gerrit-PatchSet: 1 Gerrit-Owner: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Reviewer: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-Comment-Date: Fri, 28 Sep 2018 17:31:25 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
