Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11204 )
Change subject: BTS_Tests.ttcn: fix: properly expect I-frames in f_TC_encr_cmd() ...................................................................... Patch Set 1: (2 comments) Other than cosmetic issues, looks good. https://gerrit.osmocom.org/#/c/11204/1/bts/BTS_Tests.ttcn File bts/BTS_Tests.ttcn: https://gerrit.osmocom.org/#/c/11204/1/bts/BTS_Tests.ttcn@3753 PS1, Line 3753: RslLinkId link_id, I think we aren't using this format anywhere and was first a bit confusing to me. Please format parameters accordingly. https://gerrit.osmocom.org/#/c/11204/1/bts/BTS_Tests.ttcn@3769 PS1, Line 3769: [] RSL.receive { repeat; } picky: Easier to read: Move this one up and leave timeout at the end. -- To view, visit https://gerrit.osmocom.org/11204 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I08cb28dd9fa23f3ef8b0c9ede3d4c47f5702a1c1 Gerrit-Change-Number: 11204 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Comment-Date: Wed, 03 Oct 2018 08:01:32 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No