Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11307 )
Change subject: gsm_04_08_cc: Add global guard timer for MNCC ...................................................................... Patch Set 1: Code-Review-1 (1 comment) looks good, but the actual timeout value should receive some more consideration. https://gerrit.osmocom.org/#/c/11307/1/src/libmsc/gsm_04_08_cc.c File src/libmsc/gsm_04_08_cc.c: https://gerrit.osmocom.org/#/c/11307/1/src/libmsc/gsm_04_08_cc.c@76 PS1, Line 76: #define GUARD_TIMEOUT 65 > should this be configurable? it should be configurable, and I am afraid 65 seconds is way too little. According to TS 04.07, we have something like 180 seconds of default timeout when alerting the remote end alone. This means that the phone of the called subscriber could be ringing for 3 minutes before an answer. And if the called party picks up after 2:50 minutes after starting to alert (which is probably easily more than 3 minutes after attempting the call), it is still a successful call. With 65 seconds global guard timer, we would kill the call too early. -- To view, visit https://gerrit.osmocom.org/11307 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7375d1e17cd746aac4eadfe1e587e82cf1630d3d Gerrit-Change-Number: 11307 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pma...@sysmocom.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Comment-Date: Fri, 12 Oct 2018 06:29:45 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
