Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11303 )
Change subject: gsm_08_58.h: Introduce struct abis_rsl_chan_nr ...................................................................... Patch Set 2: (2 comments) https://gerrit.osmocom.org/#/c/11303/2/include/osmocom/gsm/protocol/gsm_08_58.h File include/osmocom/gsm/protocol/gsm_08_58.h: https://gerrit.osmocom.org/#/c/11303/2/include/osmocom/gsm/protocol/gsm_08_58.h@45 PS2, Line 45: ACCHs 0x01 > It's strange, it didn't look aligned in my editor, but it did during git show. in git's patch output, the first char in each line is a diff indicator (+,-,space), so a line that has no tabs in it always appears one space further right than a line with tabs. Also tabs might snap to a different column in the diff output. https://gerrit.osmocom.org/#/c/11303/2/include/osmocom/gsm/protocol/gsm_08_58.h@85 PS2, Line 85: union abis_rsl_chan_nr chan_nr_fields; /*!< RSL channel number (value) */ (before this, the comment was spaced by tab; I don't like that, but I guess it should stay consistent to above anyway. same below.) -- To view, visit https://gerrit.osmocom.org/11303 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icd6822021207270a00106c50f8ca6b93c1250df9 Gerrit-Change-Number: 11303 Gerrit-PatchSet: 2 Gerrit-Owner: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-CC: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-CC: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-Comment-Date: Wed, 17 Oct 2018 14:22:13 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
