Harald Welte has submitted this change and it was merged. (
https://gerrit.osmocom.org/11401 )
Change subject: gprs_rlcmac_received_lost(): Fix regression / uninitialized
now_tv
......................................................................
gprs_rlcmac_received_lost(): Fix regression / uninitialized now_tv
In Change-Id I7d22e7b5902c230efeae66eb20c17026a4037887 we
introduced the use of timespecsub(). Unfortuantely, we also
accidentially removed the call to osmo_clock_gettime() along
with it, leaving now_tv completely uninitialized.
Change-Id: Ieced0c62700b2fe4ab0208258183154cc701490b
Related: OS#3225
Fixes: Coverity CID#188872
---
M src/gprs_rlcmac_meas.cpp
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Jenkins Builder: Verified
Harald Welte: Looks good to me, approved
diff --git a/src/gprs_rlcmac_meas.cpp b/src/gprs_rlcmac_meas.cpp
index f6448d5..9ff06db 100644
--- a/src/gprs_rlcmac_meas.cpp
+++ b/src/gprs_rlcmac_meas.cpp
@@ -131,6 +131,7 @@
tbf->m_bw.dl_loss_received += received;
tbf->m_bw.dl_loss_lost += lost;
+ osmo_clock_gettime(CLOCK_MONOTONIC, &now_tv);
timespecsub(&now_tv, loss_tv, &elapsed);
if (elapsed.tv_sec < 1)
return 0;
--
To view, visit https://gerrit.osmocom.org/11401
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ieced0c62700b2fe4ab0208258183154cc701490b
Gerrit-Change-Number: 11401
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte <lafo...@gnumonks.org>
Gerrit-Assignee: Stefan Sperling <ssperl...@sysmocom.de>
Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-CC: Stefan Sperling <ssperl...@sysmocom.de>
