Harald Welte has submitted this change and it was merged. (
https://gerrit.osmocom.org/11409 )
Change subject: subscr_conn_fsm: Fix null-pointer deref / N-CONNECT.ind from
unknown MSC
......................................................................
subscr_conn_fsm: Fix null-pointer deref / N-CONNECT.ind from unknown MSC
Change-Id: Id0eca3dd729d2e4c8c6ff83f05efde00b42c16f1
Fixes: Coverity CID#188860
---
M src/osmo-bsc/bsc_subscr_conn_fsm.c
1 file changed, 3 insertions(+), 2 deletions(-)
Approvals:
Harald Welte: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/src/osmo-bsc/bsc_subscr_conn_fsm.c
b/src/osmo-bsc/bsc_subscr_conn_fsm.c
index 52afd54..bca9e1f 100644
--- a/src/osmo-bsc/bsc_subscr_conn_fsm.c
+++ b/src/osmo-bsc/bsc_subscr_conn_fsm.c
@@ -276,8 +276,9 @@
if (!conn->sccp.msc) {
LOGPFSML(fi, LOGL_NOTICE, "N-CONNECT.ind from unknown
MSC %s\n",
osmo_sccp_addr_dump(&scu_prim->u.connect.calling_addr));
- osmo_sccp_tx_disconn(conn->sccp.msc->a.sccp_user,
scu_prim->u.connect.conn_id,
- &scu_prim->u.connect.called_addr,
0);
+ /* We cannot find a way to the sccp_user without the
MSC, so we cannot
+ * use osmo_sccp_tx_disconn() :( */
+ //osmo_sccp_tx_disconn(conn->sccp.msc->a.sccp_user,
scu_prim->u.connect.conn_id, &scu_prim->u.connect.called_addr, 0);
osmo_fsm_inst_term(fi, OSMO_FSM_TERM_REGULAR, NULL);
return;
}
--
To view, visit https://gerrit.osmocom.org/11409
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id0eca3dd729d2e4c8c6ff83f05efde00b42c16f1
Gerrit-Change-Number: 11409
Gerrit-PatchSet: 3
Gerrit-Owner: Harald Welte <lafo...@gnumonks.org>
Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
