Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11385 )
Change subject: Add --version cmdline option ...................................................................... Patch Set 1: Code-Review+1 the commit log mesage should state to *what* it's adding the --version. After all, gtphub is a rather exotic binary, and not the normal sgsn that one would expect in absence of any explcit mention of the binary. -- To view, visit https://gerrit.osmocom.org/11385 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icdb2bd9ec90511b51428800d17f8ce81f6804670 Gerrit-Change-Number: 11385 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osm...@sysmocom.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Comment-Date: Sun, 21 Oct 2018 12:28:02 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes
