Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11423 )

Change subject: VTY: add extended (11-bit) RACH detection toggle
......................................................................


Patch Set 1:

* did you actually do some benchmarking to see if my suspicion about 
performance impact was correct?
* it would be great if we could somehow do this automatically without having 
yet another config option at OsmoTRX.  Maybe some addition to the TRXCTRL 
protocol?  A separate verb, or something that can be stated during activation 
of the timeslot?

btw: As far as I know, the 11bit RACH (and hence TS1/TS2) is ever only used on 
RACH.  So when RACH Detection is enabled on TCH during handover, we never need 
TS1/TS2 and hence can optimize that case.


--
To view, visit https://gerrit.osmocom.org/11423
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1aee998d83b06692d76a83f79748f9129a2547e8
Gerrit-Change-Number: 11423
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy <axilira...@gmail.com>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-CC: Harald Welte <lafo...@gnumonks.org>
Gerrit-Comment-Date: Mon, 22 Oct 2018 06:50:40 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No

Reply via email to