daniel has posted comments on this change. ( https://gerrit.osmocom.org/11323 )
Change subject: stats_statsd: Send all stat_items as gauges ...................................................................... Patch Set 1: (1 comment) The stats test actually implements its own srep->send_item, so we couldn't do it through make check easily. We could do with TTCN3, but there's no support for statsd at the moment so we need that first. https://gerrit.osmocom.org/#/c/11323/1/src/stats_statsd.c File src/stats_statsd.c: https://gerrit.osmocom.org/#/c/11323/1/src/stats_statsd.c@187 PS1, Line 187: const char *unit = desc->unit; > Can you move this into the if below. I should probably just remove this as unit is no longer used and also remove the if (unit ==... check -- To view, visit https://gerrit.osmocom.org/11323 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia16270d36c9a14521594de4b99a48c83e4ac07d4 Gerrit-Change-Number: 11323 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillm...@sysmocom.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Holger Freyther <hol...@freyther.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: daniel <dwillm...@sysmocom.de> Gerrit-Reviewer: lynxis lazus <lyn...@fe80.eu> Gerrit-Comment-Date: Wed, 24 Oct 2018 14:16:25 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
