Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11130 )
Change subject: vty: SCCP timers: add optional units ...................................................................... Patch Set 2: (1 comment) I remember reading an argument against this patch regarding being different from how we handle timers in rest of osmocom code (like we always use seconds and that's all). Do we really need less-than-a-second resolution? https://gerrit.osmocom.org/#/c/11130/2/src/sccp_vty.c File src/sccp_vty.c: https://gerrit.osmocom.org/#/c/11130/2/src/sccp_vty.c@170 PS2, Line 170: whitespace -- To view, visit https://gerrit.osmocom.org/11130 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I020d5dab19bc67e8444ed548db15b2a4d8871a9c Gerrit-Change-Number: 11130 Gerrit-PatchSet: 2 Gerrit-Owner: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-CC: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Comment-Date: Tue, 30 Oct 2018 12:54:12 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
