Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11521 )

Change subject: add DLCX command statistics to osmo-mgw
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/11521/1/src/libosmo-mgcp/mgcp_protocol.c
File src/libosmo-mgcp/mgcp_protocol.c:

https://gerrit.osmocom.org/#/c/11521/1/src/libosmo-mgcp/mgcp_protocol.c@1573
PS1, Line 1573:                 OSMO_ASSERT(trunk->mgcp_dlcx_ctr_group);
> I think we can drop this kind of check, unless rate_ctr_group_alloc does a 
> lot more than just clalin […]
It doesn't hurt either.  We don't use OSMO_ASSERT() on our allocations, do we?



--
To view, visit https://gerrit.osmocom.org/11521
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0dde2faf02fd68a69f986973d39b1bea367039b
Gerrit-Change-Number: 11521
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Sperling <ssperl...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de>
Gerrit-CC: Harald Welte <lafo...@gnumonks.org>
Gerrit-Comment-Date: Wed, 31 Oct 2018 08:15:27 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Reply via email to