Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11519 )
Change subject: add aggregated rtp connection stats to osmo-mgw ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/11519/2/include/osmocom/mgcp/mgcp_conn.h File include/osmocom/mgcp/mgcp_conn.h: https://gerrit.osmocom.org/#/c/11519/2/include/osmocom/mgcp/mgcp_conn.h@64 PS2, Line 64: [RTP_OCTETS_TX_CTR] = {"all_rtp:octets_tx", "Total outbound rtp octets."}, You ar still sneaking this octets_rx/octets_tx change without at least describing it in the commit log. Best would be to have it on a separate patch. -- To view, visit https://gerrit.osmocom.org/11519 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I80d36181600901ae2e0f321dc02b5d54ddc94139 Gerrit-Change-Number: 11519 Gerrit-PatchSet: 2 Gerrit-Owner: Stefan Sperling <ssperl...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Reviewer: Stefan Sperling <ssperl...@sysmocom.de> Gerrit-Comment-Date: Wed, 31 Oct 2018 12:13:56 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
