daniel has posted comments on this change. ( https://gerrit.osmocom.org/11549 )
Change subject: contrib/jenkins.sh: Update to current osmocom infra ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Looks okay comparing it to an existing jenkins.sh in osmo-bsc https://gerrit.osmocom.org/#/c/11549/1/contrib/jenkins.sh File contrib/jenkins.sh: https://gerrit.osmocom.org/#/c/11549/1/contrib/jenkins.sh@42 PS1, Line 42: $MAKE distcheck || cat-testlogs.sh cat-testlogs.sh wouldn't actually do anything useful since we don't have tests (yet?), but it shouldn't do any harm, either. If you want to leave it in for future tests why not leave the make check call in as well since there is already an empty testsuite? -- To view, visit https://gerrit.osmocom.org/11549 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I955b99ce27df143f5d022619dd14e32b763e6c14 Gerrit-Change-Number: 11549 Gerrit-PatchSet: 1 Gerrit-Owner: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: daniel <dwillm...@sysmocom.de> Gerrit-Comment-Date: Wed, 31 Oct 2018 18:16:28 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
