Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11550 )
Change subject: RSL: restructure MDCX functions ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/11550/2/src/osmo-bsc/abis_rsl.c File src/osmo-bsc/abis_rsl.c: https://gerrit.osmocom.org/#/c/11550/2/src/osmo-bsc/abis_rsl.c@1865 PS2, Line 1865: struct msgb *rsl_make_ipacc_mdcx(uint8_t chan_nr, uint16_t conn_id, uint32_t connect_ip, uint16_t connect_port, Why not simply passing lchan and keeping all code? Lots of parameters for no apparent reason? -- To view, visit https://gerrit.osmocom.org/11550 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iffe2f4f10e841fc36965cce02b4e5f017a5ae6c8 Gerrit-Change-Number: 11550 Gerrit-PatchSet: 2 Gerrit-Owner: Max <msur...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-CC: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Comment-Date: Wed, 31 Oct 2018 19:23:20 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
