Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11551 )
Change subject: LCLS: prepare for adding new mode ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/11551/2/src/osmo-bsc/osmo_bsc_lcls.c File src/osmo-bsc/osmo_bsc_lcls.c: https://gerrit.osmocom.org/#/c/11551/2/src/osmo-bsc/osmo_bsc_lcls.c@232 PS2, Line 232: static inline void lcls_mdcx(const struct gsm_subscriber_connection *conn, struct mgcp_conn_peer *mdcx_info) Can you break adding this function and its users to a separate previous patch? you are doing several things at the same time in nearby code and it's difficult to track all changes here. -- To view, visit https://gerrit.osmocom.org/11551 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I32ba232ad802625d97a0ad9d0511edc6ac7f251c Gerrit-Change-Number: 11551 Gerrit-PatchSet: 2 Gerrit-Owner: Max <msur...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-CC: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Comment-Date: Wed, 31 Oct 2018 19:33:13 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
