Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/9374 )
Change subject: start implementing the TC_paging() PCU test ...................................................................... Patch Set 3: (1 comment) https://gerrit.osmocom.org/#/c/9374/3/pcu/PCU_Tests.ttcn File pcu/PCU_Tests.ttcn: https://gerrit.osmocom.org/#/c/9374/3/pcu/PCU_Tests.ttcn@223 PS3, Line 223: if (dec_PDU_ML3_NW_MS_backtrack(payload, pdu) != 0) { > what does this _backtrack do? The _backtrack variant of this function allows us to ignore decoding errors of unrelated Layer1 frames. The code: pdu := dec_PDU_ML3_NW_MS(payload); will sometimes result in an error such as: Dynamic test case error: While RAW-decoding type '@MobileL3_Types.PDU_ML3_NW_MS': Can not decode type '@MobileL3_Types.PDU_ML3_NW_MS', because invalid message was received The _backtrack variant returns an error code and hence allows us to skip such frames. -- To view, visit https://gerrit.osmocom.org/9374 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id0384e0742ab91983615e4f1c883bb044c1c8b18 Gerrit-Change-Number: 9374 Gerrit-PatchSet: 3 Gerrit-Owner: Stefan Sperling <ssperl...@sysmocom.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <msur...@sysmocom.de> Gerrit-Reviewer: Stefan Sperling <ssperl...@sysmocom.de> Gerrit-Comment-Date: Tue, 06 Nov 2018 12:31:28 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
