daniel has posted comments on this change. ( https://gerrit.osmocom.org/11610 )
Change subject: layer23: Avoid mempcy with NULL src ...................................................................... Patch Set 1: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/11610/1/src/host/layer23/src/common/main.c File src/host/layer23/src/common/main.c: https://gerrit.osmocom.org/#/c/11610/1/src/host/layer23/src/common/main.c@146 PS1, Line 146: if (app && app->cfg_getopt_opt) It may make more sense to check app_opp here since app->cfg_getopt_opt() could in theory omit to set app_opp or set it to NULL -- To view, visit https://gerrit.osmocom.org/11610 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I009a5b53f1e5be72ce347d64d3a7cb1d95d37ea3 Gerrit-Change-Number: 11610 Gerrit-PatchSet: 1 Gerrit-Owner: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-Reviewer: daniel <dwillm...@sysmocom.de> Gerrit-Comment-Date: Tue, 06 Nov 2018 16:58:26 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes