Max has posted comments on this change. ( https://gerrit.osmocom.org/11504 )
Change subject: gsm0808: add BSSMAP Cell Identifier matching API ...................................................................... Patch Set 4: Code-Review-1 (1 comment) I think you should also update TODO-RELEASE file as well. Provided it's still used during the release preparation. Pau? https://gerrit.osmocom.org/#/c/11504/4/src/gsm/gsm0808_utils.c File src/gsm/gsm0808_utils.c: https://gerrit.osmocom.org/#/c/11504/4/src/gsm/gsm0808_utils.c@1401 PS4, Line 1401: match_nr --; That looks odd - why space before decrement? -- To view, visit https://gerrit.osmocom.org/11504 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5535f0d149c2173294538df75764dd181b023312 Gerrit-Change-Number: 11504 Gerrit-PatchSet: 4 Gerrit-Owner: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <msur...@sysmocom.de> Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-CC: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Comment-Date: Wed, 07 Nov 2018 12:32:42 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
