Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11560 )
Change subject: replace src/* git scripts with a single src/gits ...................................................................... Patch Set 7: (3 comments) https://gerrit.osmocom.org/#/c/11560/4/src/gits File src/gits: https://gerrit.osmocom.org/#/c/11560/4/src/gits@68 PS4, Line 68: l: > This seems to work - do you get the same output with your version? […] my --porcelain --long seems to be identical to just status: ▶ git status --porcelain --long On branch neels/wip Your branch and 'origin/neels/wip' have diverged, and have 9 and 6 different commits each, respectively. (use "git pull" to merge the remote branch into yours) Untracked files: (use "git add <file>..." to include in what will be committed) ../d.bsc/ ../m2/ ../make/ ../net/config_mine ../net/config_sip ../net/my_network/ ../net/nitb/ ../net/simcards.csv ../net/sip/ ../net/tmpl_dyn/ ../openbsc/ ../quick_vty_tests.opts nothing added to commit but untracked files present (use "git add" to track) https://gerrit.osmocom.org/#/c/11560/4/src/gits@359 PS4, Line 359: def cmd_fetch(): > you don't need a shim for every git command, you can just put them in a list > and iterate over them: […] Re: shim: the best for consistent help doc is to just add a shim. Re argparse: I see .. seems to me an awful lot of trouble for just sys.argv[1:]. BTW, one thing I don't like about argparse is that it removes line feeds, i.e. paragraphs, from the doc string. In osmo_interact I did parser = argparse.ArgumentParser(description=doc, formatter_class=argparse.RawDescriptionHelpFormatter) but then you also need to take care of line feeds for option arg docs. All in all it often is more meh than yay to me. That said, if you want to change it to argparse so that it works and looks good, do go ahead in a follow-up patch. ok? https://gerrit.osmocom.org/#/c/11560/5/src/gits File src/gits: https://gerrit.osmocom.org/#/c/11560/5/src/gits@6 PS5, Line 6: # This program is free software: you can redistribute it and/or modify > Out of curiosity: why not use the shorter SPDX form? […] because I just copy-paste these things from elsewhere :P -- To view, visit https://gerrit.osmocom.org/11560 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I579e7af26d76d5c5d83b2349695456bc7b54f5a2 Gerrit-Change-Number: 11560 Gerrit-PatchSet: 7 Gerrit-Owner: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: osmith <osm...@sysmocom.de> Gerrit-Comment-Date: Wed, 07 Nov 2018 16:25:53 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
