Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11630 )
Change subject: prevent a NULL pointer dereference in debug_candidate() ...................................................................... Patch Set 1: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/11630/1/src/osmo-bsc/handover_decision_2.c File src/osmo-bsc/handover_decision_2.c: https://gerrit.osmocom.org/#/c/11630/1/src/osmo-bsc/handover_decision_2.c@844 PS1, Line 844: } AFAICT the logic was already sound. lchan->ts->trx->bts by definition is never NULL, hence we never hit a NULL dereference situation? Where is this coming from, reading code, a coverity warning or actual failure? (If this remains valid, then rather exit-early like if (!candidate->bts) return;) -- To view, visit https://gerrit.osmocom.org/11630 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie3d672d835bbc136809e593a819a6dda7c84a88e Gerrit-Change-Number: 11630 Gerrit-PatchSet: 1 Gerrit-Owner: Stefan Sperling <ssperl...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Comment-Date: Wed, 07 Nov 2018 19:15:55 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
