Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11521 )
Change subject: add DLCX command statistics to osmo-mgw ...................................................................... Patch Set 4: (1 comment) https://gerrit.osmocom.org/#/c/11521/4/src/libosmo-mgcp/mgcp_protocol.c File src/libosmo-mgcp/mgcp_protocol.c: https://gerrit.osmocom.org/#/c/11521/4/src/libosmo-mgcp/mgcp_protocol.c@a1510 PS4, Line 1510: > rate_ctr_group_alloc() may return NULL also for invalid naming, so I would > rather keep these. Seriously, you want me to change this _again_? Have you read the previous discussion? It seems this entire patch is getting hung up just because we won't agree on something as basic as how to check for allocation failures in osmocom. I'd rather keep it as it is now instead of bringing this question back up with Pau and Harald all over again. The code it would likely crash in talloc_set_destructor() on the next line anyway. By the way, shouldn't rate_ctr_group_alloc() allow its caller to differentiate between memory allocation failures and an invalid counter group description? -- To view, visit https://gerrit.osmocom.org/11521 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie0dde2faf02fd68a69f986973d39b1bea367039b Gerrit-Change-Number: 11521 Gerrit-PatchSet: 4 Gerrit-Owner: Stefan Sperling <ssperl...@sysmocom.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Reviewer: Stefan Sperling <ssperl...@sysmocom.de> Gerrit-Comment-Date: Fri, 09 Nov 2018 10:16:12 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
