Pau Espin Pedrol has submitted this change and it was merged. (
https://gerrit.osmocom.org/11680 )
Change subject: abis_nm: Allow sending and receiving Get Attributes (Response)
against nanoBTS
......................................................................
abis_nm: Allow sending and receiving Get Attributes (Response) against nanoBTS
* Allow sending Get Attributes message in abis_nm_get_attr.
* Don't try to decode Get Attribute Response Info for nanoBTS, since it
uses a different formatting than the one defined in specs.
Related: OS#3624
Change-Id: I53d01e73791cf5450aa34b1ac8f051730e3a70f9
---
M src/osmo-bsc/abis_nm.c
1 file changed, 5 insertions(+), 2 deletions(-)
Approvals:
Neels Hofmeyr: Looks good to me, approved
Max: Looks good to me, but someone else must approve
Jenkins Builder: Verified
diff --git a/src/osmo-bsc/abis_nm.c b/src/osmo-bsc/abis_nm.c
index 828d567..76fba59 100644
--- a/src/osmo-bsc/abis_nm.c
+++ b/src/osmo-bsc/abis_nm.c
@@ -566,7 +566,10 @@
abis_nm_tlv_parse(&tp, bts, foh->data, oh->length-sizeof(*foh));
- return parse_attr_resp_info(bts, trx, foh, &tp);
+ /* nanoBTS doesn't send Get Attribute Response Info, uses its own
format */
+ if (bts->type != GSM_BTS_TYPE_NANOBTS)
+ return parse_attr_resp_info(bts, trx, foh, &tp);
+ return 0;
}
/* 3GPP TS 52.021 ยง6.2.5 */
@@ -1641,7 +1644,7 @@
struct abis_om_hdr *oh;
struct msgb *msg;
- if (bts->type != GSM_BTS_TYPE_OSMOBTS) {
+ if (bts->type != GSM_BTS_TYPE_OSMOBTS && bts->type !=
GSM_BTS_TYPE_NANOBTS) {
LOGPC(DNM, LOGL_NOTICE, "Getting attributes from BTS%d type %s
is not supported.\n",
bts->nr, btstype2str(bts->type));
return -EINVAL;
--
To view, visit https://gerrit.osmocom.org/11680
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I53d01e73791cf5450aa34b1ac8f051730e3a70f9
Gerrit-Change-Number: 11680
Gerrit-PatchSet: 4
Gerrit-Owner: Pau Espin Pedrol <pes...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msur...@sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de>
