Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11735 )
Change subject: bts: Allocate TRX for BTS dynamically, deprecate -t ...................................................................... Patch Set 1: Code-Review-1 (7 comments) https://gerrit.osmocom.org/#/c/11735/1/src/common/bts.c File src/common/bts.c: https://gerrit.osmocom.org/#/c/11735/1/src/common/bts.c@108 PS1, Line 108: (and TRX) It doesn't init TRX instances anymore, right? :) https://gerrit.osmocom.org/#/c/11735/1/src/common/bts.c@197 PS1, Line 197: the BTS (and TRX) ... but this function does exactly TRX init, not BTS. https://gerrit.osmocom.org/#/c/11735/1/src/common/vty.c File src/common/vty.c: https://gerrit.osmocom.org/#/c/11735/1/src/common/vty.c@238 PS1, Line 238: bts_trx_init I think here we have possible NULL-pointer dereference. What if gsm_bts_trx_alloc() would fail and return NULL? https://gerrit.osmocom.org/#/c/11735/1/src/common/vty.c@239 PS1, Line 239: bts_model_trx_init As I can see, it's already being called from bts_trx_init(). https://gerrit.osmocom.org/#/c/11735/1/src/osmo-bts-octphy/l1_if.c File src/osmo-bts-octphy/l1_if.c: https://gerrit.osmocom.org/#/c/11735/1/src/osmo-bts-octphy/l1_if.c@795 PS1, Line 795: bts_model_trx_init For some reason, most of the 'bts_model_*' functions are here. But I think a better place is 'main.c', do you agree? https://gerrit.osmocom.org/#/c/11735/1/tests/handover/handover_test.c File tests/handover/handover_test.c: https://gerrit.osmocom.org/#/c/11735/1/tests/handover/handover_test.c@79 PS1, Line 79: open s/open/init/? https://gerrit.osmocom.org/#/c/11735/1/tests/meas/meas_test.c File tests/meas/meas_test.c: https://gerrit.osmocom.org/#/c/11735/1/tests/meas/meas_test.c@523 PS1, Line 523: open same here... -- To view, visit https://gerrit.osmocom.org/11735 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iab1a754ab12a626759f9f90aa66f87bdce65ac9c Gerrit-Change-Number: 11735 Gerrit-PatchSet: 1 Gerrit-Owner: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-Comment-Date: Mon, 12 Nov 2018 14:12:58 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes