osmith has posted comments on this change. ( https://gerrit.osmocom.org/11757 )
Change subject: gits: remove code dup: ask_reset_hard() ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/11757/1/src/gits File src/gits: https://gerrit.osmocom.org/#/c/11757/1/src/gits@273 PS1, Line 273: def ask_reset_hard(): How about moving "def ask_reset_hard()" above "def rebase()" and passing git_dir? That would make it more readable imho. -- To view, visit https://gerrit.osmocom.org/11757 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I741aa6ca29370f26a724f5b4b9c6e7f8ac3f282a Gerrit-Change-Number: 11757 Gerrit-PatchSet: 1 Gerrit-Owner: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: osmith <osm...@sysmocom.de> Gerrit-Comment-Date: Tue, 13 Nov 2018 10:36:17 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
