Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11656 )
Change subject: use enums consistently instead of falling back to int ...................................................................... Patch Set 3: (1 comment) https://gerrit.osmocom.org/#/c/11656/3/include/osmocom/sgsn/gprs_sndcp_xid.h File include/osmocom/sgsn/gprs_sndcp_xid.h: https://gerrit.osmocom.org/#/c/11656/3/include/osmocom/sgsn/gprs_sndcp_xid.h@48 PS3, Line 48: union gprs_sendcp_comp_algo { > why is it called "sendcp" while containing structs are called "sndcp"? That > looks wrong... Oops, indeed. My mistake. Fixed in next patch set. -- To view, visit https://gerrit.osmocom.org/11656 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3771a5c59f4e6fee24083b3c914965baf192cbd7 Gerrit-Change-Number: 11656 Gerrit-PatchSet: 3 Gerrit-Owner: Stefan Sperling <ssperl...@sysmocom.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Stefan Sperling <ssperl...@sysmocom.de> Gerrit-CC: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Comment-Date: Thu, 15 Nov 2018 14:57:50 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No