Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11782 )
Change subject: unlink socket path correctly in rf_create_socket() ...................................................................... Patch Set 1: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/11782/1/src/osmo-bsc/bsc_rf_ctrl.c File src/osmo-bsc/bsc_rf_ctrl.c: https://gerrit.osmocom.org/#/c/11782/1/src/osmo-bsc/bsc_rf_ctrl.c@459 PS1, Line 459: LOGP(DLINP, LOGL_ERROR, "Could not unlink socket path %s:\n", path); Please print errno or rc or whatever gives more information here. -- To view, visit https://gerrit.osmocom.org/11782 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia0c873da305cbb47aef0562f61ec21057363f294 Gerrit-Change-Number: 11782 Gerrit-PatchSet: 1 Gerrit-Owner: Stefan Sperling <ssperl...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Comment-Date: Thu, 15 Nov 2018 15:47:25 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes