Keith Whyte has uploaded this change for review. (
https://gerrit.osmocom.org/11792
Change subject: libmsc: Don't send SMS STATUS REPORT locally if ESME accepted it
......................................................................
libmsc: Don't send SMS STATUS REPORT locally if ESME accepted it
When using smpp-first, after the ESME accepts our STATUS REPORT,
we were sending it locally into gsm340_rx_sms_submit() anyway.
This would result in two copies of the status report in the SMS
database, which were also both then delivered to the MS.
This causes no visible error to the user but is a waste of radio
resources.
With this patch, we check if it is the sms_report with a receiver and
not the original SMS we are reporting on, which of course has a receiver.
Change-Id: I3529b89535800eaa1127721d613fa7bbcb8b23be
---
M src/libmsc/gsm_04_11.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/92/11792/1
diff --git a/src/libmsc/gsm_04_11.c b/src/libmsc/gsm_04_11.c
index 8d9169b..52edcd6 100644
--- a/src/libmsc/gsm_04_11.c
+++ b/src/libmsc/gsm_04_11.c
@@ -691,7 +691,7 @@
}
/* No route via SMPP, send the GSM 03.40 status-report now. */
- if (gsms->receiver)
+ if (sms_report->receiver)
gsm340_rx_sms_submit(sms_report);
LOGP(DLSMS, LOGL_NOTICE, "Status report has been sent\n");
--
To view, visit https://gerrit.osmocom.org/11792
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3529b89535800eaa1127721d613fa7bbcb8b23be
Gerrit-Change-Number: 11792
Gerrit-PatchSet: 1
Gerrit-Owner: Keith Whyte <[email protected]>
