Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11787 )
Change subject: add/clean big-endian packed structs (struct_endianess.py) ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/11787/2/include/osmocom/gsm/protocol/gsm_03_41.h File include/osmocom/gsm/protocol/gsm_03_41.h: https://gerrit.osmocom.org/#/c/11787/2/include/osmocom/gsm/protocol/gsm_03_41.h@36 PS2, Line 36: uint8_t language:4; > no, the struct is packed. They are both a single byte. […] Ah nice, I didn't know the behaviour in packet structus was also to remove padding intra-byte wise. Still I think it'd be a good idea to merge this kind of stuff into a single uint8_t, but not critical. -- To view, visit https://gerrit.osmocom.org/11787 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia0b99d76932aeb03e93bd0c62d3bf025dec5f9d2 Gerrit-Change-Number: 11787 Gerrit-PatchSet: 2 Gerrit-Owner: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Comment-Date: Mon, 19 Nov 2018 17:13:36 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
