Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/11820 )

Change subject: LCLS: update parameter representation
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/#/c/11820/2/src/osmo-bsc/osmo_bsc_lcls.c
File src/osmo-bsc/osmo_bsc_lcls.c:

https://gerrit.osmocom.org/#/c/11820/2/src/osmo-bsc/osmo_bsc_lcls.c@163
PS2, Line 163:  static struct osmo_lcls old_cfg_csc;
Not directly related to this patch, but: Shouldn't this be per-conn?



--
To view, visit https://gerrit.osmocom.org/11820
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5e962d4fbb24bf1fb2398dc13e142a4a3304d858
Gerrit-Change-Number: 11820
Gerrit-PatchSet: 2
Gerrit-Owner: Max <msur...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de>
Gerrit-Comment-Date: Tue, 20 Nov 2018 14:03:49 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes

Reply via email to