Pau Espin Pedrol has submitted this change and it was merged. ( https://gerrit.osmocom.org/11904 )
Change subject: rsl: Avoid sending ipa PDCH DEACT NACK followed by ACK ...................................................................... rsl: Avoid sending ipa PDCH DEACT NACK followed by ACK It was spotted during osmo-gsm-tester test dynts:trx-sysmocell5000+mod-bts0-dynts67-ipa+cfg-codec-fr-any that osmo-bts-trx was answering to PDCH DEACT from BSC first with a NACK followed immediatelly after by an ACK. That happens after the test does a GPRS pdp ctx act successfuly and then deactivates the ctx and the 2 MS try to place a call between them (and thus channels need to be moved to TCH/F). Most probably the if condition where the lines for this commit are modified need to be fine-grained. Patch before this one should help to understand the steates/situation in this scenario, and then a follow-up patch can be created to improve the logic. Change-Id: I91c65da6b6b7094f32187d3b083153a87c3219fd --- M src/common/rsl.c 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Jenkins Builder: Verified Vadim Yanitskiy: Looks good to me, but someone else must approve Harald Welte: Looks good to me, approved diff --git a/src/common/rsl.c b/src/common/rsl.c index d4bd2f0..b4cea2c 100644 --- a/src/common/rsl.c +++ b/src/common/rsl.c @@ -2200,11 +2200,10 @@ } if (lchan->state != LCHAN_S_NONE) { - LOGP(DRSL, LOGL_ERROR, + LOGP(DRSL, LOGL_NOTICE, "%s Request to PDCH %s, but lchan is still in state %s\n", gsm_ts_and_pchan_name(ts), pdch_act? "ACT" : "DEACT", gsm_lchans_name(lchan->state)); - rsl_tx_dyn_pdch_nack(lchan, pdch_act, RSL_ERR_NORMAL_UNSPEC); } ts->flags |= pdch_act? TS_F_PDCH_ACT_PENDING -- To view, visit https://gerrit.osmocom.org/11904 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I91c65da6b6b7094f32187d3b083153a87c3219fd Gerrit-Change-Number: 11904 Gerrit-PatchSet: 1 Gerrit-Owner: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Reviewer: Vadim Yanitskiy <axilira...@gmail.com>