Max has posted comments on this change. ( https://gerrit.osmocom.org/11929 )
Change subject: ctrl: add function to skip TRAP messages ...................................................................... Patch Set 2: (3 comments) https://gerrit.osmocom.org/#/c/11929/2/osmopy/osmo_ipa.py File osmopy/osmo_ipa.py: https://gerrit.osmocom.org/#/c/11929/2/osmopy/osmo_ipa.py@121 PS2, Line 121: if data == None or len(data) == 0: > That's not needed anymore thanks to your other commits previous to this one. I'd rather have it as explicit check in here as well: makes reasoning about the function easier. https://gerrit.osmocom.org/#/c/11929/2/osmopy/osmo_ipa.py@126 PS2, Line 126: if (int(length) != 0): > What if you have an empty IPA header How does that look like? Do you have some test case in mind? https://gerrit.osmocom.org/#/c/11929/2/osmopy/osmo_ipa.py@128 PS2, Line 128: return self.skip_traps(tail) > you need the code I commented above as a base case I don't get that. Could you rephrase it - what exactly you want to see and why? -- To view, visit https://gerrit.osmocom.org/11929 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: python/osmo-python-tests Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I51ce207c19a1ca96c3e2af7d5efd64f79b02fbb4 Gerrit-Change-Number: 11929 Gerrit-PatchSet: 2 Gerrit-Owner: Max <msur...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <msur...@sysmocom.de> Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Reviewer: daniel <dwillm...@sysmocom.de> Gerrit-Comment-Date: Mon, 26 Nov 2018 18:35:37 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No