Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11811 )
Change subject: Add expect script: 'vty' for easy access to all vtys ...................................................................... Patch Set 2: Code-Review+1 nice. I wouldn't mind at all to add it here, but it probably prefers to take on the invitation to live in libosmocore instead? agree that the commit log explanation should instead go either to a comment on top, or to some README file next to it. I think libosmocore/contrib/ is a better place than doc/examples/ (which usually is for .cfg files in other reposes) -- To view, visit https://gerrit.osmocom.org/11811 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I64ec5f2a8e04f3a8ea9cd0910ba9614fcd37ecec Gerrit-Change-Number: 11811 Gerrit-PatchSet: 2 Gerrit-Owner: Keith Whyte <ke...@rhizomatica.org> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Keith Whyte <ke...@rhizomatica.org> Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Stefan Sperling <ssperl...@sysmocom.de> Gerrit-Comment-Date: Tue, 27 Nov 2018 01:41:25 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes
