Max has posted comments on this change. ( https://gerrit.osmocom.org/11728 )
Change subject: gsm0808: add message generator for BSSMAP HANDOVER PERFORMED ...................................................................... Patch Set 6: (2 comments) https://gerrit.osmocom.org/#/c/11728/6/include/osmocom/gsm/gsm0808.h File include/osmocom/gsm/gsm0808.h: https://gerrit.osmocom.org/#/c/11728/6/include/osmocom/gsm/gsm0808.h@188 PS6, Line 188: bool lcls_bss_status_present; You can use GSM0808_LCLS_STS_NA - no need in separate bool variable. https://gerrit.osmocom.org/#/c/11728/6/src/gsm/gsm0808.c File src/gsm/gsm0808.c: https://gerrit.osmocom.org/#/c/11728/6/src/gsm/gsm0808.c@935 PS6, Line 935: if (params->lcls_bss_status_present) Same here - check for GSM0808_LCLS_STS_NA and add if it differs. -- To view, visit https://gerrit.osmocom.org/11728 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I825106858bd89afc9837811b8fed2e8accc82441 Gerrit-Change-Number: 11728 Gerrit-PatchSet: 6 Gerrit-Owner: dexter <pma...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <msur...@sysmocom.de> Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: dexter <pma...@sysmocom.de> Gerrit-CC: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Comment-Date: Fri, 30 Nov 2018 10:22:25 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
