Max has posted comments on this change. ( https://gerrit.osmocom.org/12019 )

Change subject: LCLS: fix GCR parameter name
......................................................................


Patch Set 3:

(1 comment)

It's kinda confusing when you complain about presence and absence of "<doc" at 
the same time. Please make up your mind and stick to one variant.

https://gerrit.osmocom.org/#/c/12019/3/include/osmocom/gsm/gsm0808_utils.h
File include/osmocom/gsm/gsm0808_utils.h:

https://gerrit.osmocom.org/#/c/12019/3/include/osmocom/gsm/gsm0808_utils.h@63
PS3, Line 63:   enum gsm0808_lcls_config config;   /*< doc  ยง3.2.2.116 
Configuration */
> what's "doc" about?
That was requested by you to make the comments visible to doxygen.



--
To view, visit https://gerrit.osmocom.org/12019
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8ccfbd0c146e462e599e5305520cc89602364ec3
Gerrit-Change-Number: 12019
Gerrit-PatchSet: 3
Gerrit-Owner: Max <msur...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msur...@sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de>
Gerrit-Comment-Date: Fri, 30 Nov 2018 15:34:52 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Reply via email to