Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12080 )
Change subject: Add msgb_tl_put() helper ...................................................................... Patch Set 1: Code-Review+2 (2 comments) https://gerrit.osmocom.org/#/c/12080/1/include/osmocom/gsm/tlv.h File include/osmocom/gsm/tlv.h: https://gerrit.osmocom.org/#/c/12080/1/include/osmocom/gsm/tlv.h@329 PS1, Line 329: static inline uint8_t *msgb_tl_put(struct msgb *msg, uint8_t tag) nice! https://gerrit.osmocom.org/#/c/12080/1/include/osmocom/gsm/tlv.h@334 PS1, Line 334: msgb_v_put(msg, 0); still using 'msgb_v_put' for T and L, I guess more appropriate would be 'msgb_put_u8'. But whatever. -- To view, visit https://gerrit.osmocom.org/12080 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8dc1e4880352833a0a49c1dd0d7cb4148ac43aff Gerrit-Change-Number: 12080 Gerrit-PatchSet: 1 Gerrit-Owner: Max <msur...@sysmocom.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Comment-Date: Mon, 03 Dec 2018 17:26:03 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
