daniel has posted comments on this change. ( https://gerrit.osmocom.org/12145 )
Change subject: Trap handlers: propagate expected BSC id to command processor ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/12145/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/12145/1//COMMIT_MSG@10 PS1, Line 10: when request was made, not the one which is part of the reply. Do they change? In what situation can that happen? Shouldn't we skip all changes and log an error in that case? -- To view, visit https://gerrit.osmocom.org/12145 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: python/osmo-python-tests Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6acdfddb9a1132f978f2b55c769559b0c29eb3e8 Gerrit-Change-Number: 12145 Gerrit-PatchSet: 1 Gerrit-Owner: Max <msur...@sysmocom.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Reviewer: daniel <dwillm...@sysmocom.de> Gerrit-Comment-Date: Thu, 06 Dec 2018 09:59:52 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No