Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11746 )
Change subject: Store subscriber's cell identity ...................................................................... Patch Set 2: Code-Review-1 (2 comments) https://gerrit.osmocom.org/#/c/11746/2/src/libmsc/a_iface_bssap.c File src/libmsc/a_iface_bssap.c: https://gerrit.osmocom.org/#/c/11746/2/src/libmsc/a_iface_bssap.c@51 PS2, Line 51: struct osmo_sccp_user *scu, int conn_id) TBH, this looks ugly. I am not a big fun of such fancy \t\t\t...\s\s... alignment in general, but let's don't make it even worse please ;) https://gerrit.osmocom.org/#/c/11746/2/src/libmsc/a_iface_bssap.c@321 PS2, Line 321: ci = cil.id_list[0].ci; If 'break' statement is not required here, please add a comment to suppress possible warnings (e.g. from Coverity). -- To view, visit https://gerrit.osmocom.org/11746 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8544c30ea800ce8356a227b03a8b21bf3252be7e Gerrit-Change-Number: 11746 Gerrit-PatchSet: 2 Gerrit-Owner: Max <msur...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <msur...@sysmocom.de> Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-CC: Harald Welte <lafo...@gnumonks.org> Gerrit-Comment-Date: Thu, 06 Dec 2018 11:54:31 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes