Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12221 )
Change subject: Use explicit parameter for sgsn_auth_init() ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/12221/1/tests/sgsn/sgsn_test.c File tests/sgsn/sgsn_test.c: https://gerrit.osmocom.org/#/c/12221/1/tests/sgsn/sgsn_test.c@51 PS1, Line 51: struct sgsn_instance *sgsn = &sgsn_inst; > Ah here it is. […] Probably because other tests, such as test_gmm_cancel(), still depend on the global variable. -- To view, visit https://gerrit.osmocom.org/12221 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibeba371234680f33ad35afbfffce9dca185228c1 Gerrit-Change-Number: 12221 Gerrit-PatchSet: 2 Gerrit-Owner: Max <msur...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-CC: Stefan Sperling <s...@stsp.name> Gerrit-Comment-Date: Mon, 10 Dec 2018 19:14:53 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
