Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11836 )
Change subject: chapters/gsup.adoc: document MO-/MT-forwardSM messages ...................................................................... Patch Set 4: Code-Review+2 (5 comments) I still see some of my points not addressed, but it's better to have this now than nothing. If you will, you could address below review and ping me to +2 again; or merge and come back with anoter patch later; or merge and disagree with me and I will eternally dislike it but probably forget about it soon :P https://gerrit.osmocom.org/#/c/11836/4/common/chapters/gsup.adoc File common/chapters/gsup.adoc: https://gerrit.osmocom.org/#/c/11836/4/common/chapters/gsup.adoc@509 PS4, Line 509: Direction: MSC / SGSN => SMSC (through HLR) (a nicer term is "via", not "through" ... but nm) https://gerrit.osmocom.org/#/c/11836/4/common/chapters/gsup.adoc@541 PS4, Line 541: _MO (Mobile Originated)_ short message delivery. The corresponding I still think it is really irritating to explain the same abbreviations over and over. If you have to, place the braces once above and then don't do that anymore for the rest of the doc. But actually, instead make sure MO and MT are in the glossary and then rely on that completely. We did agree on that before, right? I think we also agreed before on less fancy fontsy stuff, i.e. try to avoid italics and bold script. Especially don't place an entire "FOO (yada)" in italics? https://gerrit.osmocom.org/#/c/11836/4/common/chapters/gsup.adoc@543 PS4, Line 543: section 12.2. it's much nicer with the reference in the end, thanks :) https://gerrit.osmocom.org/#/c/11836/4/common/chapters/gsup.adoc@578 PS4, Line 578: This message is used to forward _MT (Mobile Terminated)_ short messages MT from glossary https://gerrit.osmocom.org/#/c/11836/4/common/chapters/gsup.adoc@579 PS4, Line 579: from an SMSC to MSC (CS domain) / SGSN (PS domain). The corresponding MAP and I still don't like this. I am still of the same opinion: the protocol definition is not the place to explain MSC = CS domain and SGSN = PS domain, especially not N times over and over. -- To view, visit https://gerrit.osmocom.org/11836 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie0150756c33c1352bc4eb49421824542c711175c Gerrit-Change-Number: 11836 Gerrit-PatchSet: 4 Gerrit-Owner: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-Comment-Date: Mon, 10 Dec 2018 20:46:25 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
