Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12262 )
Change subject: trx_toolkit/data_if.py: add optional legacy message coding flag ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/12262/1/src/target/trx_toolkit/data_if.py File src/target/trx_toolkit/data_if.py: https://gerrit.osmocom.org/#/c/12262/1/src/target/trx_toolkit/data_if.py@69 PS1, Line 69: payload = msg.gen_msg() Wouldn't make more sense to pass this to gen_msg and already receive a payload generated as expected? If gen_msg() is reused by several implementations, maybe adding a msg.set_legacy() API. -- To view, visit https://gerrit.osmocom.org/12262 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6b9a8b611ea1e9badc4d9ddf13aa9e237028e39a Gerrit-Change-Number: 12262 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-CC: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Comment-Date: Tue, 11 Dec 2018 18:18:54 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
