Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/12271 )
Change subject: Use msgb helper instead of local #define for debug print ...................................................................... Patch Set 1: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/12271/1/tests/gsm0808/gsm0808_test.c File tests/gsm0808/gsm0808_test.c: https://gerrit.osmocom.org/#/c/12271/1/tests/gsm0808/gsm0808_test.c@40 PS1, Line 40: #define VERIFY(msg, data, len) \ > This one can be dropped then right? I would rather change this to: #define VERIFY(msg, data) \ if (!msgb_eq_l3_data_print(msg, data, ARRAY_SIZE(data))) \ abort(); -- To view, visit https://gerrit.osmocom.org/12271 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib6be778236eff8f2153f3113f9379ecfbec9052b Gerrit-Change-Number: 12271 Gerrit-PatchSet: 1 Gerrit-Owner: Max <msur...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <msur...@sysmocom.de> Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Reviewer: Stefan Sperling <s...@stsp.name> Gerrit-Reviewer: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-Comment-Date: Wed, 12 Dec 2018 20:41:55 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes