Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12317 )
Change subject: ctrl: pass config struct to all simple_ctrl_*() ...................................................................... Patch Set 1: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/12317/1/src/simple_ctrl.c File src/simple_ctrl.c: https://gerrit.osmocom.org/#/c/12317/1/src/simple_ctrl.c@243 PS1, Line 243: const struct ctrl_cfg *cfg, struct simple_ctrl_handle *sch I'm sorry, but this is absolutely not an improvement to me. If you need the config from the handle, make the handle point to the config. Adding one extra argument to almost each function in the entire module is not an improvement. -- To view, visit https://gerrit.osmocom.org/12317 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sysmon Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I783dda27dfc5fd57401d971b2e970ede0efc7b2c Gerrit-Change-Number: 12317 Gerrit-PatchSet: 1 Gerrit-Owner: Max <msur...@sysmocom.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Comment-Date: Fri, 14 Dec 2018 15:15:15 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
