Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/12319 )

Change subject: Use absolute path for default config
......................................................................


Patch Set 1:

> > Login shell has already been added through a script, so no issue
 > with that. Let's keep the default file like in all other osmocom
 > projects.
 >
 >
 > Couldn't a long shell simply be invokved with the -c option and
 > pass an abspath? Or is that beyond the capabilities of the login
 > implementation used on systems where sysmon will be run?

I tested that and it doesn't allow passing parameters, it takes everything 
(including spaces) as path to a binary (and then is unable to find it).

Using a specific .sh file to run the command has already been tested and 
already deployed.


--
To view, visit https://gerrit.osmocom.org/12319
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sysmon
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I37c559af99872de9290335699e2118924ae2156a
Gerrit-Change-Number: 12319
Gerrit-PatchSet: 1
Gerrit-Owner: Max <msur...@sysmocom.de>
Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msur...@sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de>
Gerrit-CC: Stefan Sperling <s...@stsp.name>
Gerrit-Comment-Date: Mon, 17 Dec 2018 10:55:15 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No

Reply via email to