Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12243 )
Change subject: make gsup ipa name configurable in osmo-sgsn.cfg ...................................................................... Patch Set 3: > > Patch Set 3: > > > > > I don't see a beneficial use case in clearing the IPA name > before > > > saving the current config. Why would anyone want to omit that > name? > > > If we require the name to be stored in the config file, why > should > > > it not always be saved when the file gets written out? > > > > > > I don't get you there. I don't see anywhere that it is REQUIRED > that the name is stored in the config file. That's why we have > defaults right? When storing the config back into the cfg file we > usually have same approach. If it's the default value, don't save > it, because it means the user simply wants the default value and we > may decide later that another default value is better, this way the > user can benefit from it for free. It also keeps config files > shorter and easy to find "user specific values". > > But... wait... my patch saves the ipa-name to the config file only > if the user has overridden it. If the user does not change it, the > 'ipa-name' line won't appear in the saved configuration. > > You sound like you believed we'd save the default name > "MSC-00-00-00-00-00-00"? > That is not the case! > > Does this address your concern or did I misunderstand you? I was just replying that I still lack a "no ipa-name" in order to be able to go back to default before saving the config, but I didn't really understand your arguments against it, I was just stating I don't get them and trying to explain why. I know your patch currently doesn't do that. -- To view, visit https://gerrit.osmocom.org/12243 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib2f65fed9f56b9718e8a9647e3f01dce69870c1f Gerrit-Change-Number: 12243 Gerrit-PatchSet: 3 Gerrit-Owner: Stefan Sperling <s...@stsp.name> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <msur...@sysmocom.de> Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Reviewer: Stefan Sperling <s...@stsp.name> Gerrit-Comment-Date: Mon, 17 Dec 2018 15:33:35 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No
