Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11989 )
Change subject: gsupclient: introduce osmo_gsup_client_enc_send() ...................................................................... Patch Set 7: Code-Review+1 (3 comments) if you like, fix the doc first https://gerrit.osmocom.org/#/c/11989/4/src/gsupclient/gsup_client.c File src/gsupclient/gsup_client.c: https://gerrit.osmocom.org/#/c/11989/4/src/gsupclient/gsup_client.c@366 PS4, Line 366: * \returns 0 in case of success, otherwise -errno > Ok. osmo_gsup_client_{send,encode}() both return negative on error, and you're returning their rc, so this should also say "negative" https://gerrit.osmocom.org/#/c/11989/4/src/gsupclient/gsup_client.c@381 PS4, Line 381: if (rc) { > > to make reading code easier. […] if (rc) is fine https://gerrit.osmocom.org/#/c/11989/4/src/gsupclient/gsup_client.c@387 PS4, Line 387: if (rc) { > And here too. It's a common practice to expect 0 and nothing else. if (rc) is fine -- To view, visit https://gerrit.osmocom.org/11989 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0589ff27933e9bca2bcf93b8259004935778db8f Gerrit-Change-Number: 11989 Gerrit-PatchSet: 7 Gerrit-Owner: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <msur...@sysmocom.de> Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Stefan Sperling <s...@stsp.name> Gerrit-Reviewer: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-Comment-Date: Wed, 19 Dec 2018 18:08:05 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
